Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.rst #478

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Update install.rst #478

merged 3 commits into from
Apr 26, 2023

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Apr 21, 2023

Add a footnote explaining the most crucial observation in and linking to #473. Also update the 'latest Python version' mentioned there. Note that our pyproject.toml only includes Python versions up to 3.10, so I chose that as the 'latest version'.

Due to a recent failure of our nightly CI tests on macOS (see more details on Slack and in issue #479), we also use this PR to pin version 4.2.3 of R.

How to review

  • Build the documentation and look at the installation page.

PR checklist

  • Continuous integration checks all ✅
  • Add, expand, or update documentation.

Update latest Python version
Add footnote for #473
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #478 (10f6d0c) into main (87468c2) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #478   +/-   ##
=====================================
  Coverage   98.5%   98.5%           
=====================================
  Files         42      42           
  Lines       4489    4489           
=====================================
  Hits        4425    4425           
  Misses        64      64           

@glatterf42 glatterf42 added the docs Documentation, tutorials, etc. label Apr 21, 2023
@glatterf42 glatterf42 self-assigned this Apr 21, 2023
Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Note that these are the ixmp install instructions. We usually direct new users to the message-ix install instructions, and then ixmp gets installed as a dependency through that process—without them needing to read these separately. These are retained for completeness.

So, we should make a parallel PR with the same changes over there—would you be able to do that, or should I?

@glatterf42
Copy link
Member Author

I can do that, but I've got to take care of some other things first.

@khaeru khaeru added this to the 3.7 milestone Apr 24, 2023
@glatterf42 glatterf42 merged commit 41b6290 into main Apr 26, 2023
@glatterf42 glatterf42 deleted the issue/473 branch April 26, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation, tutorials, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants