Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chain): Add --build.tags flag for chain serve and chain build commands #3439

Merged
merged 4 commits into from
Mar 17, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Feb 20, 2023

Description

Add the --build.tags flag for the chain serve and chain build commands so we can build the binary, passing a list of tags to use in the go build command.

This will set the -tag flag for the go build and also the version.BuildTags var for the cosmos-sdk ldFlag
E.g.:

go build -tags "app_v1 netgo ledger" -ldflags '-X "github.com/cosmos/cosmos-sdk/version.BuildTags=app_v1,netgo,ledger" ...

By default, the app_v1 flag is set.

How to test

ignite chain serve -r --clear-cache --build.tags app_v1,ledger,netgo
ignite chain build --clear-cache --build.tags app_v2,ledger

@Pantani Pantani self-assigned this Feb 20, 2023
@Pantani Pantani changed the title feat: add build tags flags for serve and build commands feat(chain): Add --build.tags flags for chain serve and chain build commands Feb 20, 2023
@Pantani Pantani changed the title feat(chain): Add --build.tags flags for chain serve and chain build commands feat(chain): Add --build.tags flag for chain serve and chain build commands Feb 20, 2023
@Pantani Pantani marked this pull request as ready for review February 20, 2023 06:41
jeronimoalbi
jeronimoalbi previously approved these changes Feb 20, 2023
@ilgooz ilgooz merged commit f0bebb6 into main Mar 17, 2023
@ilgooz ilgooz deleted the feat/build-tags branch March 17, 2023 08:49
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
…ld` commands (ignite#3439)

* add build tags flags for serve and build commands

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants