feat(app_v2): detect app wiring implementation #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
requested changes
Feb 15, 2023
There was a problem hiding this comment.
I think checking against depinject.Inject (which should always present in v2 of app.go) might be a better option instead of Compose. Because compose is only used if you are defining app configuration through a Go file, alternatively you can use the app.yml format and load it in Go but this way Compose'ing will be done in the yaml file, not by calling a Go function.
… finding the `depinject.Inject` declaration
jeronimoalbi
reviewed
Mar 8, 2023
jeronimoalbi
reviewed
Mar 8, 2023
ilgooz
requested changes
Mar 17, 2023
|
@jeronimoalbi can you please review this one? |
jeronimoalbi
approved these changes
Mar 29, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
There are a couple of network test failing but otherwise LGTM 👍 |
|
I think the reason tests fail is because SPN app format is V1, so there might be an issue in the detection process. |
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* detect cosmos chain app wiring * check if the appconfig import exist * fix lint method comment * draft some changes to improve the var assign search with ast * improve the declaration search and find the app wiring implementation finding the `depinject.Inject` declaration * add changelog * add test data to a file * change the appImplementation method names to find the app.go * fix app.go search --------- Co-authored-by: İlker G. Öztürk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headline
Create a method to detect if the chain is using the app wiring trying to find the
depinject.Injectdeclaration into theapppackage files