Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify output directory. #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sundus-y
Copy link

  • Added -d option on gabc, preview and ly.
  • The -d option can be used to specify output directory.

* Added -d option on gabc, preview and ly.
* The -d option can be used to specify output directory.
@sundus-y
Copy link
Author

Solve issue #3

@igneus
Copy link
Owner

igneus commented Oct 26, 2018

Hi, thank you very much!

Looks good overall, but I guess you didn't try to actually execute gly preview with the new option: currently PreviewBuilder knows nothing about the non-default output directory, so it will still attempt to execute gregorio and lualatex in the default location.

If you have gregorio and lualatex installed (or can have them easily), please try and fix this. If you can't, please remove all changes related only to gly preview - it is valuable enough to have the option even only for gly gabc and gly ly for now.

* Fix the gly preview -d option by adding the option to the preview
  builder in addition to the preview generator.
@sundus-y
Copy link
Author

@igneus I wasn't able to install gregorio and lualatex but I think I have fixed the problem. Please help me test it. If it's still broken I will remove the -d option from the gly preview command.

@igneus
Copy link
Owner

igneus commented Oct 28, 2018

Thanks. gly preview still fails. Or better: (lua)latex executed by gly fails. The problem is latex resolves include paths relative to the "current working directory", but include paths in the main .tex document generated by gly are relative to the document location.
Preferable solution would be to run the lualatex process with "current working directory" in the output directory.

* Switch directory for runnning both `gregorio` and `lualatex` command.
@sundus-y
Copy link
Author

@igneus One last change, please test this and let me know if there is still a problem. I'm very hopeful this will fix it.

@sundus-y
Copy link
Author

sundus-y commented Nov 3, 2018

@igneus Did my last commit fix the issue?

@igneus
Copy link
Owner

igneus commented Nov 3, 2018

I'm sorry, haven't got to testing it yet. But it's either fixed or there's some really tiny bit missing. I hope you won't mind if I simply merge and supply the eventual missing bit myself afterwards. Since you cannot test with the complete tooling, it would make no sense to request further changes from you. I hope to get to this in the near future.

@sundus-y
Copy link
Author

sundus-y commented Nov 3, 2018

@igneus Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants