Fix profile action to not run frameworks (yonaskolb#1245)

* Fix profile action to not run frameworks * Add PR number to changelog * Update CHANGELOG.md Co-authored-by: Yonas Kolb <[email protected]>
iftechio · Aug 11, 2022 · e9295f1 · e9295f1
1 parent ac525a4
commit e9295f1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@
 
 - Add support for `mlmodelc` files #1236 @antonsergeev88
 
+### Fixed
+
+- Fix profile action for frameworks in Xcode 14 #1245 @SSheldon
+
 ## 2.31.0
 
 ### Added

diff --git a/Sources/XcodeGenKit/SchemeGenerator.swift b/Sources/XcodeGenKit/SchemeGenerator.swift
@@ -320,10 +320,11 @@ public class SchemeGenerator {
  )
 
  let profileAction = XCScheme.ProfileAction(
- buildableProductRunnable: runnables.profile,
+ buildableProductRunnable: shouldExecuteOnLaunch ? runnables.profile : nil,
  buildConfiguration: scheme.profile?.config ?? defaultReleaseConfig.name,
  preActions: scheme.profile?.preActions.map(getExecutionAction) ?? [],
  postActions: scheme.profile?.postActions.map(getExecutionAction) ?? [],
+ macroExpansion: shouldExecuteOnLaunch ? nil : buildableReference,
  shouldUseLaunchSchemeArgsEnv: scheme.profile?.shouldUseLaunchSchemeArgsEnv ?? true,
  askForAppToLaunch: scheme.profile?.askForAppToLaunch,
  commandlineArguments: profileCommandLineArgs,

diff --git a/Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/Framework.xcscheme b/Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/Framework.xcscheme
@@ -100,16 +100,15 @@
  savedToolIdentifier = ""
  useCustomWorkingDirectory = "NO"
  debugDocumentVersioning = "YES">
- <BuildableProductRunnable
- runnableDebuggingMode = "0">
+ <MacroExpansion>
  <BuildableReference
  BuildableIdentifier = "primary"
  BlueprintIdentifier = "AE3F93DB94E7208F2F1D9A78"
  BuildableName = "Framework.framework"
  BlueprintName = "Framework_iOS"
  ReferencedContainer = "container:Project.xcodeproj">
  </BuildableReference>
- </BuildableProductRunnable>
+ </MacroExpansion>
  </ProfileAction>
  <AnalyzeAction
  buildConfiguration = "Production Debug">