feat: #1789 migrate chart tests to use react testing library #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also noticed a really minor issue that the second hex string in these colorSchemes appears incorrect. It makes areas in some charts appear grey. Rather than guessing a good value, I decided not to include that yet. I'm not as good with color and I kind of liked the grey. |
julianguyen
approved these changes
Oct 4, 2020
| import { ChartControl } from 'components/Chart/ChartControl'; | ||
|
|
||
| /** | ||
| * Canvas is tricky to test with 'react-testing-library', so this file mocks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate Chart and ChartControl tests to use React Testing Library instead of Enzyme
More Details
In addition to updating the tests, this PR also adds a couple of other optional dev dependencies:
@testing-library/user-event:
Although the
fireEventthat comes with RTL is sufficient for the purpose of this PR, I saw that this dependency came recommended, so I thought to include it here. If its inclusion here is premature, I can definitely roll it back.canvas:
Although the tests still pass without this one, it was displaying the error below (in the Screenshots section).
Corresponding Issue
#1789
Screenshots
As always, if anything looks out of place (or missing), please LMK and I'll make the necessary changes.
Thank you! ☕
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!