Add Bookmark switch to Moments and Strategies #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianguyen
reviewed
Apr 21, 2020
julianguyen
reviewed
Apr 24, 2020
app/helpers/moments_form_helper.rb
Outdated
| def moment_form_inputs | ||
| [ | ||
| moment_name, moment_why, moment_fix, moment_category, moment_mood, | ||
| moment_strategy, get_viewers_input( | ||
| @viewers, 'moment', 'moments', @moment | ||
| ), | ||
| moment_comment, moment_publishing | ||
| moment_comment, moment_publishing, | ||
| Rails.env.development? ? moment_bookmarked : '' |
There was a problem hiding this comment.
Instead of returning an empty string if the env if production, I think it should be nil.
There was a problem hiding this comment.
Hi @julianguyen, some tests seem to fail when I make this change. I had noticed this previously and hence replaced it with an empty string. Is there another way to solve this?
app/helpers/strategies_helper.rb
Outdated
| @@ -34,6 +34,7 @@ def strategy_form_inputs(strategy, viewers) | |||
| get_viewers_input(viewers, 'strategy', 'strategies', strategy), | |||
| build_strategy_comment(strategy), build_strategy_publishing(strategy), | |||
| build_strategy_visible(strategy), | |||
| Rails.env.development? ? build_strategy_bookmarked(strategy) : '', | |||
There was a problem hiding this comment.
Similar comment as above, let's replace the empty string with nil.
julianguyen
reviewed
Apr 25, 2020
julianguyen
approved these changes
Apr 25, 2020
|
Sure @julianguyen! I agree, this is a feature that a lot of users would like to have! |
|
That would be great! :) It would be helpful to continue to scope the work based on what @LMulvey had laid things out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added column 'bookmarked: boolean' to Moments and Strategies table.
Created a bookmark toggle on the Moments/Strategies page.
This is a subtask for issue #187
Screenshots
Corresponding Issue
#1580
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!