Issue 1655 moment moods cleanup #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianguyen
previously approved these changes
Feb 21, 2020
|
Looks like you'll want to rebase and resolve some conflicts before we merge. |
julianguyen
approved these changes
Feb 22, 2020
julianguyen
approved these changes
Feb 22, 2020
| @@ -3,10 +3,10 @@ module CommonMethods | |||
| extend ActiveSupport::Concern | |||
|
|
|||
| def mood_names_and_slugs | |||
| return unless attribute(:mood) | |||
| return unless self.class.reflect_on_association(:moods) | |||
julianguyen
reviewed
Feb 22, 2020
| @@ -26,9 +26,10 @@ def viewable?(item) | |||
| def get_data_type(model_object, data_type) | |||
| data = [] | |||
| model_object.select do |item| | |||
| next unless item[data_type].any? && viewable?(item) | |||
| objs = data_type == 'moods' ? item.moods.pluck(:id) : item[data_type] | |||
There was a problem hiding this comment.
We should eventually extract this into helper and generalize this for categories and strategies. This can be handled in a subsequent PR.
nshki
reviewed
Feb 22, 2020
| @@ -0,0 +1,5 @@ | |||
| class DropMomentsMoodColumn < ActiveRecord::Migration[5.2] | |||
| def change | |||
| remove_column :moments, :mood | |||
There was a problem hiding this comment.
Likely won't be a big deal, but dropping a column can cause exceptions during deployment until the app is rebooted. If we want to avoid that, it's recommended that we queue up two migrations and deploy them separately.
There was a problem hiding this comment.
Ahh I see. Thanks for the link.
|
I think this should be safe to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes Moment#mood column and works with the join table relation instead.
There's a lot of shared code and metaprogramming related to strategies and categories. Since the old field was named
mood(singular) and the proper relation ismoods, there is some code based aroundmoodbeing examined. When other models get properly related, the conditional statements will go away.Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!