Add 'tini' as init #178
Merged
Add 'tini' as init #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iegomez
requested changes
Jun 2, 2021
|
@kfdm There's a typo that needs changing. |
iegomez
requested changes
Jun 2, 2021
docker/Dockerfile
Outdated
| @@ -41,7 +41,7 @@ RUN mkdir mosquitto-go-auth && \ | |||
| FROM debian:stable-slim | |||
|
|
|||
| #Get mosquitto dependencies. | |||
| RUN apt-get update && apt-get install -y libwebsockets8 libc-ares2 openssl uuid | |||
| RUN apt-get update && apt-get install -y libwebsockets8 libc-ares2 openssl uuid tiny | |||
There was a problem hiding this comment.
Suggested change
| RUN apt-get update && apt-get install -y libwebsockets8 libc-ares2 openssl uuid tiny | |
| RUN apt-get update && apt-get install -y libwebsockets8 libc-ares2 openssl uuid tini |
|
Woops, sorry about the typo there. I likely only tested the base Docker image and neglected to test the other one 🙇 This should explain things in detail krallin/tini#8 (comment) |
iegomez
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of containers try to avoid using
shellfor the ENTRYPOINT due to issues with escaping characters and not always handling signals very well. Many use tini as a way to handle this.This is configured so that it is also easy to replace CMD with your own value without affecting the init.