Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on backend error #124

Merged
merged 2 commits into from
Mar 7, 2021
Merged

Retry on backend error #124

merged 2 commits into from
Mar 7, 2021

Conversation

PierreF
Copy link
Contributor

@PierreF PierreF commented Nov 13, 2020

Port of jpmens/mosquitto-auth-plug#144

Allow to retry call to backend in case of error. This is useful if there are multiple backends behind a load-balancer and some backend are unhealthy (e.g. during canary deployment, where some backend use a new - bugged - version).

The default is to not retry, as this feature is not needed for every backend.

It's based on #120 because otherwise a conflict will occur. Since #120 contains lots of change, this PR should probably be only reviewed after #120 is merged (or only have a look at the 2nd commit).

This should be the last PR I made for this week :) Thanks for your works on this project, I hope all those PR won't give you too much work.

@PierreF
Copy link
Contributor Author

PierreF commented Feb 11, 2021

This PR is based (or include) PR #120. I think once PR #120 got merged, the conflict will disappear. So doing nothing for now to avoid complicating git history.

Copy link
Owner

@iegomez iegomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, there are some discrepancies that should be solved with a rebase and force pushing the branch. I'll be able to properly review after that.

README.md Outdated Show resolved Hide resolved
auth-plugin.c Outdated Show resolved Hide resolved
auth-plugin.c Outdated Show resolved Hide resolved
@PierreF PierreF merged commit 76e798c into iegomez:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants