Add Docker image to run tests #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @PierreF! Thanks so much for this, I've been meaning to add something similar but never found the time. I won't be able to review it properly until next week since I won't have my dev machine during the weekend, but I'll take a look as soon as possible. |
|
That's fine for me, thank for the quick reply. |
If an old image is usage, not running apt-get update may cause 404 error when trying to install packages. This is true even if there is apt-get update in previous RUN instruction, because the way Docker cache thing, previous RUN of apt-get update may use cached version (which could be weeks old).
This avoid trying to access service while it still starting. This happened with Redis cluster.
This make much easier to re-run test multiple time without avoid to wait backends to start each time.
iegomez
reviewed
Mar 4, 2021
|
It's the same as base Dockerfile (just the end that change). https://github.com/mattn/go-sqlite3 seems to bundle sqlite3 code in its repository (sqlite3-binding.c), which means sqlite3 get bundled in both source code and then in binary (static linking). |
|
Oh, interesting! TIL. |
iegomez
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run tests (which requires lots of backends), I've used Docker containers.
This PR add steps to rebuild and run test using this Docker image.
It's probably not prefect (sometime Redis cluster fail... not every run) but it allow me to run the tests.