Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT checkers and JS mode #116

Merged
merged 2 commits into from
Feb 11, 2021
Merged

JWT checkers and JS mode #116

merged 2 commits into from
Feb 11, 2021

Conversation

iegomez
Copy link
Owner

@iegomez iegomez commented Nov 6, 2020

This PR adds:

  • A JS interpreter runner, right now creating a VM on every check since it's not thread-safe. I'm probably gonna add a pool of VMs to improve it, but first I need to try it.
  • A major cleanup of JWT backend, creating a checker interface that js, local and remote modes fulfill right now (not entirely ready). This makes it a lot easier to add the files-like check (jwt-backend local but without db. Use rsa public-key for secret. #90), with or without the discussed custom syntax (bear with me guys, I'm getting there) as an option for this backend.
  • A new Javascript backend.

@iegomez
Copy link
Owner Author

iegomez commented Feb 9, 2021

@PierreF, this is the JWT changes PR that I mentioned I've been working on. They are ready and tested, but I'd be happy to read your thoughts or any comments you may have before merging since they'll affect your work.

Once merged, my absolute priority is to review your PRs after adjusted.

Cheers!

@iegomez iegomez changed the title JS interpreter grounds and JWT checkers JWT checkers and JS mode Feb 9, 2021
@iegomez
Copy link
Owner Author

iegomez commented Feb 11, 2021

And I just went along and added a separate JS backend of itself because it was straightforward.
Let me know about anything or I'll merge tomorrow so we can get things moving.

…and local mode, allow local mode specific DB options instead of sharing with regular DB backends.
@iegomez iegomez force-pushed the feat/jwt-add-js-interpreter branch 2 times, most recently from 18719fc to fc5484a Compare February 11, 2021 13:58
@iegomez iegomez merged commit f8108eb into master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant