Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide pre built binaries #162

Closed
ShivamJoker opened this issue Mar 18, 2021 · 14 comments · Fixed by #253
Closed

Provide pre built binaries #162

ShivamJoker opened this issue Mar 18, 2021 · 14 comments · Fixed by #253

Comments

@ShivamJoker
Copy link

Hey, it will be great if we can use pre built binaries with mosquitto or we can try compiling both in one package if it won't work independently.

@iegomez
Copy link
Owner

iegomez commented Mar 20, 2021

Hi, @ShivamJoker!
I'm not sure about releasing binaries since the plugin needs to be compiled against specific versions of Mosquitto to work correctly because their plugin interface is different per version. Also, it's a bit of a burden to release binaries when compiling the project is fairly easy. I will give it a thought, but don't expect binary releases any soon.

@ShivamJoker
Copy link
Author

At least we can do for the latest version of mosquitto and we can use GitHub actions as well to automatically compile it.

@iegomez
Copy link
Owner

iegomez commented Mar 20, 2021

That sounds like something I'd be more willing to maintain, but I haven't played with github actions yet. Want to take a shot at it and open a PR?

@ShivamJoker
Copy link
Author

Sure, I can give it a try but I may need bit of guidance.

Will it directly work if I just compile and get the goauth.so file ?

@iegomez
Copy link
Owner

iegomez commented Mar 22, 2021

Thanks!

Will it directly work if I just compile and get the goauth.so file ?

I'm not entirely sure what you mean by that.

@ShivamJoker
Copy link
Author

ShivamJoker commented Mar 23, 2021

I mean the steps you have provided in readme for building the plugin with mosquitto.

What do I need to do after that ?

@iegomez
Copy link
Owner

iegomez commented Apr 1, 2021

I don't know if there's an automated way to release binaries based on GitHub actions builds, I'll have to look that up.

@ShivamJoker
Copy link
Author

@iegomez I am asking is the goauth.so file we need to make this plugin work with mosquitto ?

@iegomez
Copy link
Owner

iegomez commented Apr 2, 2021

Yeah, goauth.so is the only thing needed, it's the shared object that Mosquitto loads.

@iegomez
Copy link
Owner

iegomez commented Jul 31, 2021

@ShivamJoker any updates on this? Let me know if I can close it otherwise.

Cheers!

@ShivamJoker
Copy link
Author

Hey sorry I got caught up but I'll definitely try this week

@ShivamJoker
Copy link
Author

What I am thinking is we already have an image on dockerhub and we are publishing it on every release
And here is the action for it by @arctic-alpaca
https://github.com/iegomez/mosquitto-go-auth/blob/master/.github/workflows/build_and_push_docker_images.yml

What we can do is run the container with the image and copy the goauth.so file and publish it to github releases.

I also don't have much experience with the workflows if @arctic-alpaca can help it would be great.

@arctic-alpaca
Copy link
Contributor

I can't currently help much with this sorry.

A first step could be to document how to get the goauth.so file from a Docker container to help people who can't compile it themselves.

I'm not sure whether this is relevant. Are there differences in the resulting goauth.so file depending on whether glibc or musl is used by the building OS? I think I remember some issues with the Docker containers with alpine.

@iegomez
Copy link
Owner

iegomez commented Jun 10, 2022

I'm closing this for now, feel free to reopen it if there are any updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants