Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve renderer and middleware #323

Merged
merged 1 commit into from
Jun 8, 2024
Merged

feat: improve renderer and middleware #323

merged 1 commit into from
Jun 8, 2024

Conversation

chenshenhai
Copy link
Member

  • feat(renderer): improve renderer for rect, path and group
  • feat(core): add event for controlling snapToGrid in selector middleware
  • feat(idraw): add feature of controlling snapToGrid

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 6.54%. Comparing base (6786f97) to head (ac60ce4).
Report is 121 commits behind head on main.

Files Patch % Lines
packages/core/src/middleware/selector/index.ts 0.00% 16 Missing and 6 partials ⚠️
packages/renderer/src/draw/path.ts 0.00% 10 Missing and 3 partials ⚠️
packages/core/src/middleware/selector/config.ts 0.00% 3 Missing ⚠️
packages/idraw/src/idraw.ts 0.00% 1 Missing and 1 partial ⚠️
packages/renderer/src/draw/group.ts 0.00% 1 Missing and 1 partial ⚠️
packages/renderer/src/draw/rect.ts 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #323      +/-   ##
========================================
- Coverage   6.56%   6.54%   -0.03%     
========================================
  Files        105     105              
  Lines       6716    6742      +26     
  Branches    1308    1315       +7     
========================================
  Hits         441     441              
- Misses      5022    5041      +19     
- Partials    1253    1260       +7     
Flag Coverage Δ
unittests 6.54% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenshenhai chenshenhai merged commit ac206ca into main Jun 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants