sysstat-12.3.3

sysstat version 12.3.3 final packaging. lsm and spec files updated. Changelog added. Year of (C) message updated. Exciting new features in this version include: * sar/sadc collect and display Pressure-Stall Information statistics. These metrics have been added during the 4.20 development cycle of the Linux kernel. They can be displayed with "sar -q {CPU | LOAD | MEM}". * iostat has gained support devices managed by drivers in userspace like spdk (see sysstat#257). New flags (-f / +f) have been added so that the user can specify an alternate location for statistics files. This version also includes various bug fixes. Enjoy! Signed-off-by: Sebastien GODARD <[email protected]>
idfumg · May 8, 2020 · 2e46917 · 2e46917
1 parent d1bad83
commit 2e46917
Show file tree

Hide file tree

Showing 56 changed files with 140 additions and 115 deletions.
diff --git a/BUG_REPORT b/BUG_REPORT
@@ -16,3 +16,5 @@ Actual behavior: [What actually happened]
 Additional info: [Include gist of relevant binary system activity datafile, config, logs, etc.
 or send them directly to me at sysstat <at> orange_dot_fr]
 
+Opening an issue on GitHub is the preferred way to report a bug.
+
diff --git a/CHANGES b/CHANGES
@@ -1,5 +1,26 @@
 Changes:
 
+2020/05/08: Version 12.3.3 - Sebastien Godard (sysstat <at> orange.fr)
+ * sar/sadc: Add new Pressure-Stall Information (PSI) statistics.
+ * sadf: Add support for PSI statistics.
+ * iostat: Add support for devices managed by userspace drivers (e.g. spdk).
+ Add new flags -f/+f to specify an alternate location for stats files.
+ * sar: Don't display duplicate entries in /etc/mtab [12.2.2].
+ * sar: Don't display "Inconsistent input data" error message when no
+ activities are collected by sadc.
+ * sadf: XML: Remove "per" attribute for memory activity.
+ * sadf: Add new option "hz=" for datafile conversion.
+ * Various updates to remove GCC v9/v10 warnings.
+ * sar: Don't check if we are close enough to selected interval when
+ interval=1 [12.2.2].
+ * sadf: Use actual number of items, not its pointer address [12.2.2].
+ * [Sdrkun]: sa1: Create default sa directory if it doesn't exist [12.2.2].
+ * pr_stats.c: Printing timestamp should appear only once [12.2.2].
+ * common.c: Remove unused get_dev_part_nr() function [12.2.2].
+ * DTD and XSD documents updated.
+ * sar and sadf manual pages updated.
+ * Non regression tests updated. New tests added (sar, iostat).
+
 2020/04/10: Version 12.3.2 - Sebastien Godard (sysstat <at> orange.fr)
  * pidstat: Major code refactoring. Several bugs fixed.
  * pidstat: Don't display unneeded spaces following command name

diff --git a/Makefile.in b/Makefile.in
@@ -1,5 +1,5 @@
 # Makefile to build sysstat commands
-# (C) 1999-2019 Sebastien GODARD (sysstat <at> orange.fr)
+# (C) 1999-2020 Sebastien GODARD (sysstat <at> orange.fr)
 
 # Version and package name
 VERSION = @PACKAGE_VERSION@

diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@
 [![Total Alerts](https://img.shields.io/lgtm/alerts/g/sysstat/sysstat.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/sysstat/sysstat/alerts)
 [![Donate](https://img.shields.io/badge/Donate-PayPal-blue.svg)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=45U6F9R73ESFQ)
 
-(C) 1999-2019 Sebastien GODARD (sysstat (at) orange (dot) fr)
+(C) 1999-2020 Sebastien GODARD (sysstat (at) orange (dot) fr)
 
 ### Introduction
 
@@ -46,6 +46,7 @@ Default sampling interval is 10 minutes but this can be changed of course (it ca
 - Power management statistics (instantaneous and average CPU clock frequency, fans speed, devices temperature, voltage inputs)
 - USB devices plugged into the system
 - Filesystems utilization (inodes and blocks)
+- Pressure-Stall Information statistics
 
 #### Sysstat key features:
 - Display average statistics values at the end of the reports.
@@ -56,6 +57,7 @@ Default sampling interval is 10 minutes but this can be changed of course (it ca
 - Needs very little CPU time to run (written in C).
 - System statistics collected by sar/sadc can be saved in a file for future inspection. You can configure the length of data history to keep. There is no limit for this history length but the available space on your storage device.
 - System statistics collected by sar/sadc can be exported in various different formats (CSV, XML, JSON, SVG, etc.). DTD and XML Schema documents are included in sysstat package. JSON output format is also available for mpstat and iostat commands.
+- iostat can display statistics for devices managed by drivers in userspace like spdk.
 - Smart color output for easier statistics reading.
 
 ![Smart color output](images/color_output.png)
@@ -167,7 +169,7 @@ that should be provided for this.
 Please also remember to read the FAQ that comes with sysstat or is available
 from the Wiki page on GitHub.
 
-Opening a pull request is the preferred way to submit a patch.
+Opening an issue or a pull request on GitHub is the preferred way to report a bug or submit a patch.
 Patches and suggestions for improvements are always welcome!
 
 ### Support sysstat!

diff --git a/activity.c b/activity.c
@@ -1,6 +1,6 @@
 /*
  * activity.c: Define system activities available for sar/sadc.
- * (C) 1999-2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 1999-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/common.c b/common.c
@@ -1,6 +1,6 @@
 /*
  * sar, sadc, sadf, mpstat and iostat common routines.
- * (C) 1999-2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 1999-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/common.h b/common.h
@@ -1,6 +1,6 @@
 /*
  * sysstat: System performance tools for Linux
- * (C) 1999-2019 by Sebastien Godard (sysstat <at> orange.fr)
+ * (C) 1999-2020 by Sebastien Godard (sysstat <at> orange.fr)
  */
 
 #ifndef _COMMON_H

diff --git a/count.c b/count.c
@@ -1,6 +1,6 @@
 /*
  * count.c: Count items for which statistics will be collected.
- * (C) 1999-2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 1999-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/count.h b/count.h
@@ -1,7 +1,7 @@
 /*
  * count.h: Include file used to count items for which
  * statistics will be collected.
- * (C) 1999-2019 by Sebastien Godard (sysstat <at> orange.fr)
+ * (C) 1999-2020 by Sebastien Godard (sysstat <at> orange.fr)
  */
 
 #ifndef _COUNT_H

diff --git a/format.c b/format.c
@@ -1,6 +1,6 @@
 /*
  * format.c: Output format definitions for sadf and sar
- * (C) 2011-2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 2011-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/iostat.c b/iostat.c
@@ -1,6 +1,6 @@
 /*
  * iostat: report CPU and I/O statistics
- * (C) 1998-2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 1998-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/iostat.h b/iostat.h
@@ -1,6 +1,6 @@
 /*
  * iostat: report CPU and I/O statistics
- * (C) 1999-2019 by Sebastien Godard (sysstat <at> orange.fr)
+ * (C) 1999-2020 by Sebastien Godard (sysstat <at> orange.fr)
  */
 
 #ifndef _IOSTAT_H

diff --git a/json_stats.c b/json_stats.c
@@ -1,6 +1,6 @@
 /*
  * json_stats.c: Funtions used by sadf to display statistics in JSON format.
- * (C) 1999-2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 1999-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/json_stats.h b/json_stats.h
@@ -1,6 +1,6 @@
 /*
  * json_stats.h: Include file used to display system statistics in JSON format.
- * (C) 1999-2019 by Sebastien Godard (sysstat <at> orange.fr)
+ * (C) 1999-2020 by Sebastien Godard (sysstat <at> orange.fr)
  */
 
 #ifndef _JSON_STATS_H

diff --git a/mpstat.c b/mpstat.c
@@ -1,6 +1,6 @@
 /*
  * mpstat: per-processor statistics
- * (C) 2000-2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 2000-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/mpstat.h b/mpstat.h
@@ -1,6 +1,6 @@
 /*
  * mpstat: per-processor statistics
- * (C) 2000-2019 by Sebastien Godard (sysstat <at> orange.fr)
+ * (C) 2000-2020 by Sebastien Godard (sysstat <at> orange.fr)
  */
 
 #ifndef _MPSTAT_H

diff --git a/nls/sysstat.pot b/nls/sysstat.pot
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: sysstat <at> orange.fr\n"
-"POT-Creation-Date: 2020-05-08 09:24+0200\n"
+"POT-Creation-Date: 2020-05-08 09:52+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[email protected]>\n"
@@ -17,11 +17,44 @@ msgstr ""
 "Content-Type: text/plain; charset=CHARSET\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-#: cifsiostat.c:75 tapestat.c:104 mpstat.c:134 iostat.c:89 sar.c:108
+#: pr_stats.c:2616 pr_stats.c:2623 pr_stats.c:2728 pr_stats.c:2773
+msgid "Summary:"
+msgstr ""
+
+#: iostat.c:89 cifsiostat.c:75 mpstat.c:134 tapestat.c:104 sar.c:108
 #, c-format
 msgid "Usage: %s [ options ] [ <interval> [ <count> ] ]\n"
 msgstr ""
 
+#: iostat.c:92
+#, c-format
+msgid ""
+"Options are:\n"
+"[ -c ] [ -d ] [ -h ] [ -k | -m ] [ -N ] [ -s ] [ -t ] [ -V ] [ -x ] [ -y ] "
+"[ -z ]\n"
+"[ { -f | +f } <directory> ] [ -j { ID | LABEL | PATH | UUID | ... } ]\n"
+"[ --dec={ 0 | 1 | 2 } ] [ --human ] [ -o JSON ]\n"
+"[ [ -H ] -g <group_name> ] [ -p [ <device> [,...] | ALL ] ]\n"
+"[ <device> [...] | ALL ] [ --debuginfo ]\n"
+msgstr ""
+
+#: iostat.c:99
+#, c-format
+msgid ""
+"Options are:\n"
+"[ -c ] [ -d ] [ -h ] [ -k | -m ] [ -N ] [ -s ] [ -t ] [ -V ] [ -x ] [ -y ] "
+"[ -z ]\n"
+"[ { -f | +f } <directory> ] [ -j { ID | LABEL | PATH | UUID | ... } ]\n"
+"[ --dec={ 0 | 1 | 2 } ] [ --human ] [ -o JSON ]\n"
+"[ [ -H ] -g <group_name> ] [ -p [ <device> [,...] | ALL ] ]\n"
+"[ <device> [...] | ALL ]\n"
+msgstr ""
+
+#: iostat.c:2165 sa_common.c:2329
+#, c-format
+msgid "Invalid type of persistent device name\n"
+msgstr ""
+
 #: cifsiostat.c:79
 #, c-format
 msgid ""
@@ -71,18 +104,6 @@ msgstr ""
 msgid "Cannot handle so many processors!\n"
 msgstr ""
 
-#: tapestat.c:106
-#, c-format
-msgid ""
-"Options are:\n"
-"[ --human ] [ -k | -m ] [ -t ] [ -V ] [ -y ] [ -z ]\n"
-msgstr ""
-
-#: tapestat.c:272
-#, c-format
-msgid "No tape drives with statistics found\n"
-msgstr ""
-
 #: mpstat.c:137
 #, c-format
 msgid ""
@@ -96,35 +117,6 @@ msgstr ""
 msgid "Average:"
 msgstr ""
 
-#: iostat.c:92
-#, c-format
-msgid ""
-"Options are:\n"
-"[ -c ] [ -d ] [ -h ] [ -k | -m ] [ -N ] [ -s ] [ -t ] [ -V ] [ -x ] [ -y ] "
-"[ -z ]\n"
-"[ { -f | +f } <directory> ] [ -j { ID | LABEL | PATH | UUID | ... } ]\n"
-"[ --dec={ 0 | 1 | 2 } ] [ --human ] [ -o JSON ]\n"
-"[ [ -H ] -g <group_name> ] [ -p [ <device> [,...] | ALL ] ]\n"
-"[ <device> [...] | ALL ] [ --debuginfo ]\n"
-msgstr ""
-
-#: iostat.c:99
-#, c-format
-msgid ""
-"Options are:\n"
-"[ -c ] [ -d ] [ -h ] [ -k | -m ] [ -N ] [ -s ] [ -t ] [ -V ] [ -x ] [ -y ] "
-"[ -z ]\n"
-"[ { -f | +f } <directory> ] [ -j { ID | LABEL | PATH | UUID | ... } ]\n"
-"[ --dec={ 0 | 1 | 2 } ] [ --human ] [ -o JSON ]\n"
-"[ [ -H ] -g <group_name> ] [ -p [ <device> [,...] | ALL ] ]\n"
-"[ <device> [...] | ALL ]\n"
-msgstr ""
-
-#: iostat.c:2165 sa_common.c:2329
-#, c-format
-msgid "Invalid type of persistent device name\n"
-msgstr ""
-
 #: sadf.c:105
 #, c-format
 msgid ""
@@ -148,8 +140,21 @@ msgstr ""
 msgid "PCP support not compiled in\n"
 msgstr ""
 
-#: pr_stats.c:2616 pr_stats.c:2623 pr_stats.c:2728 pr_stats.c:2773
-msgid "Summary:"
+#: tapestat.c:106
+#, c-format
+msgid ""
+"Options are:\n"
+"[ --human ] [ -k | -m ] [ -t ] [ -V ] [ -y ] [ -z ]\n"
+msgstr ""
+
+#: tapestat.c:272
+#, c-format
+msgid "No tape drives with statistics found\n"
+msgstr ""
+
+#: common.c:79
+#, c-format
+msgid "sysstat version %s\n"
 msgstr ""
 
 #: sar.c:123
@@ -344,16 +349,6 @@ msgstr ""
 msgid "Cannot find the data collector (%s)\n"
 msgstr ""
 
-#: rd_stats.c:359
-#, c-format
-msgid "Cannot read %s\n"
-msgstr ""
-
-#: common.c:79
-#, c-format
-msgid "sysstat version %s\n"
-msgstr ""
-
 #: sa_conv.c:99
 #, c-format
 msgid "Cannot convert the format of this file\n"
@@ -489,6 +484,11 @@ msgstr ""
 msgid " \t[Unknown format]"
 msgstr ""
 
+#: rd_stats.c:359
+#, c-format
+msgid "Cannot read %s\n"
+msgstr ""
+
 #: sa_common.c:302
 #, c-format
 msgid "File created by sar/sadc from sysstat version %d.%d.%d"

diff --git a/pcp_def_metrics.c b/pcp_def_metrics.c
@@ -1,6 +1,6 @@
 /*
  * pcp_def_metrics.c: Funtions used by sadf to define PCP metrics
- * (C) 2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 2019-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/pcp_def_metrics.h b/pcp_def_metrics.h
@@ -1,6 +1,6 @@
 /*
  * pcp_def_metrics.h: Include file used to define PCP metrics.
- * (C) 2019 by Sebastien Godard (sysstat <at> orange.fr)
+ * (C) 2019-2020 by Sebastien Godard (sysstat <at> orange.fr)
  */
 
 #ifndef _PCP_DEF_METRICS_H

diff --git a/pcp_stats.c b/pcp_stats.c
@@ -1,6 +1,6 @@
 /*
  * pcp_stats.c: Funtions used by sadf to create PCP archive files.
- * (C) 2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 2019-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/pcp_stats.h b/pcp_stats.h
@@ -1,6 +1,6 @@
 /*
  * pcp_stats.h: Include file used to display system statistics in PCP format.
- * (C) 2019 by Sebastien Godard (sysstat <at> orange.fr)
+ * (C) 2019-2020 by Sebastien Godard (sysstat <at> orange.fr)
  */
 
 #ifndef _PCP_STATS_H

diff --git a/pidstat.c b/pidstat.c
@@ -1,6 +1,6 @@
 /*
  * pidstat: Report statistics for Linux tasks
- * (C) 2007-2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 2007-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/pidstat.h b/pidstat.h
@@ -1,6 +1,6 @@
 /*
  * pidstat: Display per-process statistics.
- * (C) 2007-2019 by Sebastien Godard (sysstat <at> orange.fr)
+ * (C) 2007-2020 by Sebastien Godard (sysstat <at> orange.fr)
  */
 #ifndef _PIDSTAT_H
 #define _PIDSTAT_H

diff --git a/pr_stats.c b/pr_stats.c
@@ -1,6 +1,6 @@
 /*
  * pr_stats.c: Functions used by sar to display statistics
- * (C) 1999-2019 by Sebastien GODARD (sysstat <at> orange.fr)
+ * (C) 1999-2020 by Sebastien GODARD (sysstat <at> orange.fr)
  *
  ***************************************************************************
  * This program is free software; you can redistribute it and/or modify it *

diff --git a/pr_stats.h b/pr_stats.h
@@ -1,6 +1,6 @@
 /*
  * pr_stats.h: Include file used to display system statistics
- * (C) 1999-2019 by Sebastien Godard (sysstat <at> orange.fr)
+ * (C) 1999-2020 by Sebastien Godard (sysstat <at> orange.fr)
  */
 
 #ifndef _PR_STATS_H