Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .webp images. #153

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Add support for .webp images. #153

merged 4 commits into from
Jan 10, 2023

Conversation

Wicloz
Copy link
Contributor

@Wicloz Wicloz commented Sep 16, 2021

WebP images are getting increasingly more common, and Pillow supports this format. Adding it to the list of valid formats is the only change required to make this work.

WebP images are getting increasingly more common, and Pillow supports this format. Adding it to the list of valid formats is the only change required to make this work.
@tanujjain
Copy link
Collaborator

Could you please update the test cases?

@Wicloz Wicloz force-pushed the patch-1 branch 2 times, most recently from 59a2021 to 8c8255d Compare December 30, 2022 02:22
@Wicloz
Copy link
Contributor Author

Wicloz commented Dec 30, 2022

Excuses for the spam but this should be correct. I also tried adding an image file in a format not mentioned to be supported but it got recognized anyway, so either these tests are not correct or the list of recognized formats is not complete.

@tanujjain
Copy link
Collaborator

tanujjain commented Jan 2, 2023

@Wicloz Thanks for the changes. The formats included in the package are the ones where we explicitly tested that duplicates could be found reliably. In fact, before merging this PR, I'll create an artificial dataset comprising of near duplicates with webp format to check that duplicates can be found reliably. So, didn't include every format PIL is capable of supporting. Instead, going with the community requests for the format support here.

Also, changing the base branch for merge to be dev as per contribution guidelines.

@tanujjain tanujjain changed the base branch from master to dev January 2, 2023 14:42
@tanujjain tanujjain merged commit a2b0837 into idealo:dev Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants