Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Several PostProcessors from RAVEN to SR2ML #1553

Merged
merged 15 commits into from
May 18, 2021
Merged

Move Several PostProcessors from RAVEN to SR2ML #1553

merged 15 commits into from
May 18, 2021

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented May 13, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

close #1552
In order to move these PostProcessors to SR2ML, the PostProcessorReadyInterface class is created for temporarily handle the situation: some PostProcessors are using 'dict' as in and out operations, while others using 'xarray.Dataset' as in and out operations.
Most of the methods from PostProcessorPluginBase are moved to PostProcessorReadyInterface.

When all internal PostProcessors are converted to only use 'xarray.Dataset' as in and out operation. The class 'PostProcessorReadyInterface' and 'PostProcessorInterface' will be merged to form the new base class for all PostProcessors.

The corresponding PR in SR2ML is: idaholab/SR2ML#22

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05 wangcj05 requested review from alfoa and mandd May 14, 2021 04:14
@wangcj05 wangcj05 added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label May 14, 2021
@wangcj05
Copy link
Collaborator Author

@alfoa @mandd This PR is ready for you to review. Please also check PR: idaholab/SR2ML#22

mandd
mandd previously approved these changes May 14, 2021
Copy link
Collaborator

@alfoa alfoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only few comments

@alfoa
Copy link
Collaborator

alfoa commented May 18, 2021

@wangcj05 once merged, please send an email to the user list to inform that the CPRA/DPRA specific PP have been moved to SR2ML.

@alfoa
Copy link
Collaborator

alfoa commented May 18, 2021

Checklist passed (pending tests).

Approved...

Merging once tests pass.

@alfoa
Copy link
Collaborator

alfoa commented May 18, 2021

RrR in qsub failing @wangcj05

@moosebuild
Copy link

Job Test qsubs on f9566e9 : invalidated by @wangcj05

retest tests/framework/CodeInterfaceTests/RAVEN/ReturnDatabase

@alfoa
Copy link
Collaborator

alfoa commented May 18, 2021

Checklist passed .

Approved...

Merging...

@wangcj05
Copy link
Collaborator Author

@alfoa Qsub Test is green now. I have tested the failed test on my local machine, so far no failed case (63 in total, no failed case)

@alfoa alfoa merged commit 7629328 into devel May 18, 2021
@alfoa alfoa deleted the wangc/pp_sr2ml branch May 18, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Move Several PostProcessors from RAVEN to SR2ML
4 participants