Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyError: 'alternative' attribute was not found in the photo field #859

Closed
smaugfm opened this issue Jun 1, 2024 · 1 comment
Closed

KeyError: 'alternative' attribute was not found in the photo field #859

smaugfm opened this issue Jun 1, 2024 · 1 comment
Labels
bug

Comments

@smaugfm
Copy link

smaugfm commented Jun 1, 2024

Overview

After update to 1.19.0 I occasionally get this errors:

KeyError: 'alternative' attribute was not found in the photo fields.

I traced the error to this line:

icloud_photos_downloader/src/pyicloud_ipd/utils.py

Line 113 in b49194c

if "adjusted" in _results and _results["original"]["filename"] == _results["adjusted"]["filename"]:

Here are a couple of icloudpd-photo-error.jsons:
https://gist.github.com/smaugfm/9fbed4bd93a7ae637dac289a6d54867f
https://gist.github.com/smaugfm/4e065051c455592e36d926bb68512dbf

Steps to Reproduce

Seems to happen with MOV files, HEIC files, etc.
@smaugfm smaugfm added the bug label Jun 1, 2024
AndreyNikiforov added a commit that referenced this issue Jun 2, 2024
@AndreyNikiforov
Fix KeyError #859 (#861)
48d6fd0
@AndreyNikiforov
Copy link
Collaborator

fixed in 1.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreyNikiforov @smaugfm