Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add viewport scale to screenshot data #2449

Merged
merged 1 commit into from
May 25, 2024
Merged

Add viewport scale to screenshot data #2449

merged 1 commit into from
May 25, 2024

Conversation

bungoboingo
Copy link
Contributor

Addresses this, which I thought I already merged 😅

Fixes:

  • When using the widget bounds operation, the bounds are returned in logical pixels
  • When using the screenshot command, the screenshot is taken in physical pixels
  • When cropping a screenshot, we need to know the scale factor of the viewport to properly screenshot an individual widget

@hecrj hecrj added this to the 0.13 milestone May 25, 2024
@hecrj hecrj added feature New feature or request rendering addition labels May 25, 2024
hecrj
hecrj approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks 🎉

@hecrj hecrj merged commit 8d1e639 into iced-rs:master May 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
addition feature New feature or request rendering
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bungoboingo @hecrj