Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't consume unused scroll events #2397

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Don't consume unused scroll events #2397

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58c2749
Initial Commit
Koranir Apr 21, 2024
d91a207
Update scrollable.rs
Koranir Apr 21, 2024
f758031
Use `let _ = ` instead of `_ =` for consistency
hecrj Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use let _ = instead of _ = for consistency
  • Loading branch information
@hecrj
hecrj committed Apr 23, 2024
commit f7580317e271e0d84d6dce34dd1ac987cddf0abf
10 changes: 5 additions & 5 deletions widget/src/scrollable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ where
Some(cursor_position);

// TODO: bubble up touch movements if not consumed.
_ = notify_on_scroll(
let _ = notify_on_scroll(
state,
&self.on_scroll,
bounds,
Expand Down Expand Up @@ -519,7 +519,7 @@ where
content_bounds,
);

_ = notify_on_scroll(
let _ = notify_on_scroll(
state,
&self.on_scroll,
bounds,
Expand Down Expand Up @@ -557,7 +557,7 @@ where

state.y_scroller_grabbed_at = Some(scroller_grabbed_at);

_ = notify_on_scroll(
let _ = notify_on_scroll(
state,
&self.on_scroll,
bounds,
Expand Down Expand Up @@ -590,7 +590,7 @@ where
content_bounds,
);

_ = notify_on_scroll(
let _ = notify_on_scroll(
state,
&self.on_scroll,
bounds,
Expand Down Expand Up @@ -628,7 +628,7 @@ where

state.x_scroller_grabbed_at = Some(scroller_grabbed_at);

_ = notify_on_scroll(
let _ = notify_on_scroll(
state,
&self.on_scroll,
bounds,
Expand Down
Loading