Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always mask text in tiny_skia renderer #2234

Closed
wants to merge 1 commit into from

Conversation

Koranir
Copy link
Contributor

@Koranir Koranir commented Feb 3, 2024

Fixes #2173
Not sure exactly why physical_bounds says it isn't in the clip_bounds, but looking into the tiny_skia code it seems that there isn't any performance hit if we add a mask or not.

@hecrj
Copy link
Member

hecrj commented Feb 11, 2024

looking into the tiny_skia code it seems that there isn't any performance hit if we add a mask or not

How so? It seems to me that the presence of a mask does add a new blitting stage:

https://github.com/RazrFalcon/tiny-skia/blob/ce3fe9bab0659fb928d6c22c03b74e009a8a2b77/src/pipeline/blitter.rs#L86-L88

@hecrj hecrj closed this Feb 11, 2024
@hecrj hecrj added bug Something isn't working performance fix labels Feb 11, 2024
@hecrj hecrj added this to the 0.12 milestone Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiny-skia does not truncate long text outside of Element when it is inside a Column
2 participants