Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate private and public interfaces #8

Closed
wants to merge 1 commit into from

Conversation

warmwaffles
Copy link

@warmwaffles warmwaffles commented Aug 6, 2021

This is a common pattern that I've seen that helps convey what is supposed to be public and what is internal and not to be used directly.

I don't know if this is something you are interested in.

With this change it would possible to remove the #define __PHYSICSFS_INTERNAL__ before the internal include since the include directory should be the only directory a user should be including within their project. Of course that would necessitate a change to remove the #error out of the internal include, but that can be another change later.

This is a common pattern that I've seen that helps convey what is
supposed to be public and what is internal and not to be used directly.
@warmwaffles warmwaffles deleted the separate-internals branch January 17, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant