Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: explicitly link to advapi32 and shell32 #55

Merged
merged 2 commits into from
Apr 27, 2023
Merged

cmake: explicitly link to advapi32 and shell32 #55

merged 2 commits into from
Apr 27, 2023

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Apr 27, 2023

This fixes unresolved external symbols when building physfs for ARM:

     Creating library D:/a/physfs/physfs/build/Debug/physfs.lib and object D:/a/physfs/physfs/build/Debug/physfs.exp
physfs_platform_windows.obj : error LNK2019: unresolved external symbol __imp_OpenProcessToken referenced in function __PHYSFS_platformCalcUserDir [D:\a\physfs\physfs\build\physfs.vcxproj]
physfs_platform_windows.obj : error LNK2019: unresolved external symbol __imp_SHGetFolderPathW referenced in function __PHYSFS_platformCalcPrefDir [D:\a\physfs\physfs\build\physfs.vcxproj]
D:\a\physfs\physfs\build\Debug\physfs.dll : fatal error LNK1120: 2 unresolved externals [D:\a\physfs\physfs\build\physfs.vcxproj]

Also bump the actions/checkout action to fix node deprecation warnings.

madebr referenced this pull request Apr 27, 2023
@madebr @sezero
cmake: fix warnings + use target_include_directories
aabb732
@icculus icculus merged commit 57d36e0 into icculus:main Apr 27, 2023
@madebr madebr deleted the fix-cmake-for-arm branch April 27, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@madebr @icculus