Supporting windows 125x encoding for filenames in VDF. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to be clear, is it a specific Windows 125x codepage, or can it be any of these 9 without any indication as to which? https://en.wikipedia.org/wiki/Windows_code_page#Windows-125x_series We need to be able to turn this into UTF-8, and maybe that means we pretend it's 1252 and that's the best we can do...? |
|
It could be any of Windows 125x encodings. I don't think that UTF-8 can be used here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed encoding type from ASCII to Windows 125x for filenames in VDF. Right now some vdf files are not loaded, because some characters in filenames exeed 127 limit.