Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest IBPSA master #196

Closed
dhblum opened this issue Apr 29, 2020 · 2 comments
Closed

Update to latest IBPSA master #196

dhblum opened this issue Apr 29, 2020 · 2 comments

Comments

@dhblum
Copy link
Collaborator

dhblum commented Apr 29, 2020

Unit tests are failing with the most recent merge to the IBPSA master: ibpsa/modelica-ibpsa#1340. The message is as follows:

From test_data.py
=========================
Of 14 tests run...
Passed: 12
Failures: 1
Errors: 1
Failure Messages
----------------
Failure 0:
Traceback (most recent call last):
  File "/usr/local/testing/test_data.py", line 61, in test_generate_weather
    self.compare_ref_timeseries_df(df_gen, ref_filepath)
  File "/usr/local/testing/utilities.py", line 101, in compare_ref_timeseries_df
    self.assertTrue(results['Pass'], '{0} Key is {1}.'.format(results['Message'],key))
AssertionError: Max error (0.00940195134318) in trajectory greater than tolerance (0.001) at index 27. y_test: 0.010521042, y_ref:0.01061984 Key is HDirNor.
Error Messages
----------------
Error 0:
Traceback (most recent call last):
  File "/usr/local/testing/test_data.py", line 221, in test_save_data_and_kpisjson
    self.man.save_data_and_kpisjson(fmu_path=self.case.fmupath)
  File "/usr/local/testing/data/data_manager.py", line 223, in save_data_and_kpisjson
    self._append_csv_data()
  File "/usr/local/testing/data/data_manager.py", line 170, in _append_csv_data
    'key, it is in the format: variable[zone_identifier] '.format(col,f))
KeyError: 'The data column ceiHei from file /usr/local/testing/testcase2/models/Resources/weather.csv does not match any of the allowed column keys and therefore it cannot be saved within the compiled fmu. Test case data variables are used for forecasting and KPI calculation. If you want this variable to be part of the test case data make sure that the column has a key with any of the specified formats in categories.json and that, if it is a zone related key, it is in the format: variable[zone_identifier] '

In particular, the weather bus output celHei was changed to ceiHei, requiring the same change to data/categories.json.

@dhblum
Copy link
Collaborator Author

dhblum commented Apr 29, 2020

Updates merged in #189.

dhblum added a commit that referenced this issue Apr 29, 2020
@dhblum dhblum closed this as completed in ec58968 Apr 29, 2020
@dhblum
Copy link
Collaborator Author

dhblum commented Apr 29, 2020

Closed by #189 via #188.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant