Improve props argument type in Transforms.setNodes()

[e1himself]

Description

Because Typescript can know which type of nodes we are modifying thanks to the T type inferred from the match function, if available, it can also properly narrow down the props argument type.

Checks

• The new code matches the existing patterns and styles.
• The tests pass with yarn test.
• The linter passes with yarn lint. (Fix errors with yarn fix.)
• The relevant examples still work. (Run examples with yarn start.)
• You've added a changeset if changing functionality. (Add one with yarn changeset add.)

[changeset-bot]

🦋 Changeset detected

Latest commit: 0a54efd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
slate	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[e1himself]

Is there anything I should do additionally to submitting a PR to get this viewed by someone? Like pinging a maintainer? :)

Didn't find anything specific to that in the contribution guide.

[dylans]

Is there anything I should do additionally to submitting a PR to get this viewed by someone? Like pinging a maintainer? :)

Didn't find anything specific to that in the contribution guide.

Apologies, just a busy week. I had reviewed it when it was first submitted and it looked good to me, but I tend to leave things open for a few days in case others on the team want to chime in. Going to accept this now and it will be in the next release. Thanks for the contribution!

[htulipe]

This PR breaks some valid use case like switching from a bullet to a numbered list:

Transforms.setNodes(
      editor,
      { type: ElementType.NumberedList },
      { match: isBulletedListElement }
    );
    
function isBulletedListElement(
  node: Node
): node is BulletedListSlateElement {
  return Element.isElement(node) && node.type === ElementType.BulletedList;
}  

TS complains it can't set type to ElementType.NumberedList because it must be of type ElementType.BulletedList | undefined

[e1himself]

@htulipe
I believe this can be handled by explicitly telling TS that you are okay switching node type:

Transforms.setNodes<BulletedListSlateElement | NumberedListSlateElement>(
      editor,
      { type: ElementType.NumberedList },
      { match: isBulletedListElement }
);
    
function isBulletedListElement(
  node: Node
): node is BulletedListSlateElement {
  return Element.isElement(node) && node.type === ElementType.BulletedList;
}