-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looking for feedback: Move from monad-control & lifted-base to unliftio. #22
Comments
@dfithian would be particularly interested to hear from you on this if you've got any opinions on it. I expect people using |
Out of the country right now but will look next week
…On Wed, Jun 20, 2018, 19:46 Ian Duncan ***@***.***> wrote:
@dfithian <https://github.com/dfithian> would be particularly interested
to hear from you on this if you've got any opinions on it. I expect people
using withDogStatsD itself in one of the 'dangerous' transformers are few
and far between.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIBQ6IZt37-nkQK5xFWV2gJX7yd3wGjaks5t-t68gaJpZM4UwnXx>
.
|
This is the first time I've heard of unliftio. It looks like the advantage is that you can provide an implementation for running a monad transformer stack without pinning the makeup of the monad stack itself. Is that right? In addition, another advantage would be that one could nest |
I would say that given the ResourceT problem presents as a runtime error I'd be very careful about this change and make sure that it's not only called out in the README. Also potentially not completely rewriting the API but deprecating the old API and providing a new implementation. |
Okay I'm totally on the MonadUnliftIO bandwagon now. Having used it this week I'm heavily in favor of banishing ExceptT to purgatory. |
👍 glad to hear it. I think given that Yesod has dropped |
I'm considering switching over from uses of monad-control to unliftio. A few of the reasons:
MonadBaseControl
in Handlers.MonadBaseControl
(see https://www.fpcomplete.com/blog/2017/06/tale-of-two-brackets). In the case ofdatadog
's usage, bracketing is one of the main reasons that we use it, so I'd like to restrict usage to a safer subset of monad transformers.Any feedback is welcome, but thinking about doing a major release with #18 and #21 soon, so it'd be a good time to make the transition.
The text was updated successfully, but these errors were encountered: