Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] KMD - Komodo #142

Merged
merged 1 commit into from
Dec 13, 2017
Merged

[ADD] KMD - Komodo #142

merged 1 commit into from
Dec 13, 2017

Conversation

ca333
Copy link
Contributor

@ca333 ca333 commented Dec 4, 2017

Komodo chainparams and derivation path conf based on KMDs registered cointype from BIP44 list of satoshilabs- https://github.com/satoshilabs/slips/blob/master/slip-0044.md

@iancoleman iancoleman merged commit ab1bd64 into iancoleman:master Dec 13, 2017
@mikeyb
Copy link
Contributor

mikeyb commented Dec 19, 2017

This should be reverted or corrected. I would assume all addresses this is generating for KMD are invalid.

@iancoleman
Copy link
Owner

@ca333 - where did the original address in the test come from? I am also getting a failure for this test the same way @mikeyb gets, so it seems at least the behaviour is consistent.

Please clarify why your original version of the test fails.

jsarenik pushed a commit to jsarenik/bip39 that referenced this pull request Sep 16, 2020
@iancoleman
Merge pull request iancoleman#142 from ca333/master
648f438 
[ADD] KMD - Komodo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ca333 @mikeyb @iancoleman