Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Java CI Small Fix #566

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Java CI Small Fix #566

merged 1 commit into from
Jan 14, 2022

Conversation

DartPower
Copy link
Contributor

  • Update checkout module
  • Increment Java JDK version
  • Add artifact upload
  • Test older mc versions with newest java
  • Test artifact target path correctly or not too much (i guess it's OK)

This is very small fix but i think it's helpful :)

@DartPower DartPower mentioned this pull request Jan 13, 2022
@datatags
Copy link
Collaborator

I'm not familiar with GitHub actions, but is there a way to provide multiple Java versions for compiling? I believe UC requires Java 8, 16, and 17 to compile correctly. This is a step in the right direction though 🙂

@DartPower
Copy link
Contributor Author

DartPower commented Jan 14, 2022

I'm too not much expert in Github Actions but i have a two ideas: (and/or)

  1. You can split repo in multiple branches by version and edit in workflow file branch trigger by branch.
  2. You can create multiple workflow files with each java version.

Just example, but useful.
And also i can find method to cross-compile by java version.

@datatags
Copy link
Collaborator

I'll just merge this and poke around a little. Let me know if you have any other thoughts. Thanks! :)

@datatags datatags merged commit 652d5e1 into iSach:master Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants