Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Add v1_16_R3 Adapter #522

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Add v1_16_R3 Adapter #522

merged 2 commits into from
Dec 7, 2020

Conversation

NikitaCartes
Copy link
Contributor

@NikitaCartes NikitaCartes commented Nov 6, 2020

This is almost my first experience with bukkit/spigot plugin so I can did something wrong.

Difference between v1_16_R2 and v1_16_R3

I checked here for differences in mapping but didn't notice anything that plugin use.

So I copied v1_16_R2 to v1_16_R3 with replacment.

And all works fine except one things:

> Task :v1_16_R3:compileJava FAILED
/home/nikita/git/UltraCosmetics/v1_16_R3/src/main/java/be/isach/ultracosmetics/v1_16_R3/nms/WrapperEntityLiving.java:110: error: dM() has protected access in EntityLiving
        return handle.dM();
                     ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

FAILURE: Build failed with an exception.

I don't know how to properly fix this, so I added dirty hack and always return 0 for this functions. Didn't notice any visual bugs for now.

Attached compiled jar in releases in fork, I think it can be useful.
https://github.com/NikitaCartes-forks/UltraCosmetics/releases/tag/2.5.10-beta.1

@lgtm-com
Copy link

lgtm-com bot commented Nov 13, 2020

This pull request introduces 4 alerts and fixes 1 when merging 6b00940 into 39fa1d6 - view on LGTM.com

new alerts:

  • 3 for Dereferenced variable may be null
  • 1 for Useless type test

fixed alerts:

  • 1 for Type mismatch on container access

@Emibergo02
Copy link

it is handle.dN() for 1.16.4. fix it

@lgtm-com
Copy link

lgtm-com bot commented Dec 7, 2020

This pull request introduces 2 alerts and fixes 3 when merging 3e0cc44 into 39fa1d6 - view on LGTM.com

new alerts:

  • 1 for Useless type test
  • 1 for Dereferenced variable may be null

fixed alerts:

  • 3 for Expression always evaluates to the same value

@iSach iSach merged commit 1720c1c into iSach:master Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants