Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

A mount and a few fixes #41

Merged
merged 14 commits into from
Jan 24, 2016
Merged

A mount and a few fixes #41

merged 14 commits into from
Jan 24, 2016

Conversation

JHXSMatthew
Copy link
Contributor

  1. Copy your work and mess them into one mount "flying boat", I cannot think any good english name for it . You may change it to something much more interesting.
    • it's a boat could flying around like EnderDragon
    • Right click or left click will spawn an TNT , when the TNT reaches the ground, it will explode. Cooldown 10 seconds without any message or actionbar notification (not like gadgets).
    • Uhm... What's more ?
  2. Fix TreasureChest class's import stuff.

Cheers!

@iSach
Copy link
Owner

iSach commented Jan 23, 2016

Hey, once more thanks for your contributions again.

I can't work a lot these days because of school.

For the boat, Flying Ship could be cool, as it drops bombs.

What was bugging with treasure chests?

@JHXSMatthew
Copy link
Contributor Author

For treasure chests, I forgot to import the class "fixedMetaValue" in last pull request.
This pull request just patches this .

I would create new pull request with name changing soon.
Cheers!

@iSach
Copy link
Owner

iSach commented Jan 23, 2016

Okay, thanks!

@JHXSMatthew
Copy link
Contributor Author

Changed.

It looks like every file I modify a bit has to be "re-written" (- all original lines and + again).
I have no ideas why this happens.
What's encoding do you use for each file , GBK or utf-8 or something else?

@JHXSMatthew
Copy link
Contributor Author

for commit ed32f6c
just fix #39 by removing the import "bungee's stuff".

@iSach
Copy link
Owner

iSach commented Jan 24, 2016

Thanks again.

I use UTF-8. I'm gonna work on it today.

I must find the reason of armor stand pets' name tags not disappearing. I'm the only person not getting this issue.

Then all the known bugs should be fixed. I will also do some testings.

iSach added a commit that referenced this pull request Jan 24, 2016
Many bugfixes and new Mount. Thanks a lot to JHXSMatthew (MatthewYu)
@iSach iSach merged commit dd03465 into iSach:master Jan 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants