Skip to content

Commit

Permalink
Fix experimental k8s run (pulumi#1192)
Browse files Browse the repository at this point in the history
Two small changes to the workflow definition.
Firstly 'concurrency' doesn't apply across a build matrix, so use
max-parallel instead.

Secondly, always run the infra cleanup even if the k8s job failed.
  • Loading branch information
Frassle committed Mar 7, 2022
1 parent 483b55e commit 267b3a3
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ jobs:
- testing-unit-go
kubernetes:
name: kubernetes
concurrency: kubernetes-${{ github.sha }}-${{ github.run_number }}
needs: test-infra-setup
env:
PULUMI_EXPERIMENTAL: ${{ matrix.experimental }}
Expand Down Expand Up @@ -153,6 +152,7 @@ jobs:
set -euo pipefail
cd misc/test && go test . --timeout 4h -v -json -count=1 -short -parallel 40 --tags=all --run=TestAccKubernetes 2>&1 | tee /tmp/gotest.log | gotestfmt
strategy:
max-parallel: 1
fail-fast: false
matrix:
dotnet-version:
Expand Down Expand Up @@ -467,6 +467,8 @@ jobs:
test-infra-destroy:
name: test-infra-destroy
needs: kubernetes
# Always clean up the test infrastructure even if the k8s jobs failed
if: ${{ always() }}
runs-on: ${{ matrix.platform }}
steps:
- name: Install DotNet ${{ matrix.dotnet-version }}
Expand Down

0 comments on commit 267b3a3

Please sign in to comment.