Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

includes is not supported on older browsers #1597

Merged
merged 1 commit into from
Apr 6, 2021
Merged

includes is not supported on older browsers #1597

merged 1 commit into from
Apr 6, 2021

Conversation

gmi182
Copy link
Contributor

@gmi182 gmi182 commented Apr 6, 2021 •
edited
Loading

Because of #1596
I'm issueing a PR to address includes not being supported on older browsers.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • documentation is changed or added

@adrai
Copy link
Member

adrai commented Apr 6, 2021

Can you confirm this is the only change for IE11 compatibility?
Can't ensure the IE11 compatibility will be validated in future releases anyway...

@gmi182
Copy link
Contributor Author

gmi182 commented Apr 6, 2021

@adrai, AFAIK, that's the only problem I was facing with an older browser.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.158% when pulling fb50636 on gmi182:master into 5d59625 on i18next:master.

@adrai adrai merged commit 692f72f into i18next:master Apr 6, 2021
@adrai
Copy link
Member

adrai commented Apr 6, 2021

v20.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrai adrai adrai left review comments

@Dakkers Dakkers Dakkers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gmi182 @adrai @coveralls @Dakkers