Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Macedonian plural formula - *11 (11, 111, 211, 311, 58711...) is plural #1476

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Jul 1, 2020

The problem noticed on https://treker.mk/mk/stats, fixed for the project with treker-mk/website#28
according to https://unicode-org.github.io/cldr-staging/charts/37/supplemental/language_plural_rules.html#mk

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • documentation is changed or added

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.604% when pulling b8bdb50 on stefanb:patch-1 into 72c5009 on i18next:master.

@stefanb stefanb changed the title Added exception for 11, 111, 211, 311... in Macedonian language fix: Macedonian plural formula - *11 (11, 111, 211, 311, 58711...) remain plural Jul 1, 2020
@stefanb stefanb changed the title fix: Macedonian plural formula - *11 (11, 111, 211, 311, 58711...) remain plural fix: Macedonian plural formula - *11 (11, 111, 211, 311, 58711...) is plural Jul 1, 2020
@adrai adrai merged commit e3ad1ad into i18next:master Jul 2, 2020
@adrai
Copy link
Member

adrai commented Jul 2, 2020

included in v19.5.3

@adrai
Copy link
Member

adrai commented Jul 2, 2020

If you like this module don’t forget to star this repo. Make a tweet, share the word or have a look at our https://locize.com to support the devs of this project.

There are many ways to help this project 🙏

@stefanb stefanb deleted the patch-1 branch July 2, 2020 07:31
stefanb added a commit to sledilnik/website that referenced this pull request Jul 5, 2020
i18next v19.5.3 includes our fix i18next/i18next#1476
we upgraded to to 19.5.4 in #434
stefanb added a commit to sledilnik/website that referenced this pull request Jul 5, 2020
i18next v19.5.3 includes our fix i18next/i18next#1476
we upgraded to to 19.5.4 in #434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants