Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript testing #1165

Merged
merged 4 commits into from
Jan 11, 2019
Merged

Add typescript testing #1165

merged 4 commits into from
Jan 11, 2019

Conversation

tkow
Copy link
Contributor

@tkow tkow commented Jan 11, 2019

If it isn't needed, close it.

@coveralls
Copy link

coveralls commented Jan 11, 2019

Coverage Status

Coverage remained the same at 88.413% when pulling a3547e2 on tkow:feature/add_dts_test into a06a2c4 on i18next:master.

@rosskevin rosskevin self-assigned this Jan 11, 2019
@rosskevin
Copy link
Collaborator

@jamuhl is travis not running the test script? This PR should be broken at this point, I was just checkpointing some changes to the ts setup and I know they are broken locally. Sinc. show all checks just shows code climate I'm concerned that PRs are not being tested.

@rosskevin rosskevin changed the title Feature/add dts test Add typescript testing Jan 11, 2019
@jamuhl
Copy link
Member

jamuhl commented Jan 11, 2019

@rosskevin shows failed on https://travis-ci.org/i18next/i18next but not here...will need to check why

@rosskevin
Copy link
Collaborator

oh, shows building now...

@jamuhl
Copy link
Member

jamuhl commented Jan 11, 2019

@rosskevin still worked here: #1163

@jamuhl
Copy link
Member

jamuhl commented Jan 11, 2019

@rosskevin might have been just a glitch

@rosskevin rosskevin merged commit 3be868a into i18next:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants