Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ppb_flash_navigate #9

Closed
wants to merge 1 commit into from
Closed

Implement ppb_flash_navigate #9

wants to merge 1 commit into from

Conversation

evilpie
Copy link
Contributor

@evilpie evilpie commented May 24, 2014

Should fix issue #8

@i-rinat
Copy link
Owner

i-rinat commented May 24, 2014

Can't merge, sorry. There are couple of issue with this patch: (i) no POST support and (ii) possible call of npn.geturl from non-main thread. There is already some race condition issues in my code, so it's not a good idea to add another one.

@i-rinat
Copy link
Owner

i-rinat commented May 24, 2014

I'll add missing pieces to ppb_url_loader, and then reuse it in ppb_flash_navigate.

@evilpie evilpie closed this May 24, 2014
@i-rinat i-rinat added this to the v0.1.0 milestone Jun 8, 2014
@maxwux maxwux mentioned this pull request Aug 17, 2014
Closed
@lashkevi lashkevi mentioned this pull request Jul 3, 2015
Closed
@newspaperman newspaperman mentioned this pull request Jul 16, 2015
Closed
@jccardot jccardot mentioned this pull request Nov 28, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evilpie @i-rinat