Update Fortran interfaces in Struct #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfalgout
reviewed
Jul 6, 2020
rfalgout
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
Hi @victorapm . This looks good, except for the SparseMSG solver stuff. Thanks for updating this!
|
Thanks, Rob! I removed support to SparseMSG in commit 24fb670. Can I go ahead and merge? |
|
It’s fine with me. Did you want @ulrikeyang to approve too? I see that she is listed as a reviewer. |
|
Yes, Rob! I'll wait for her approval. Thanks! |
ulrikeyang
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the
HYPRE_*SetPrecondfunctions implemented instruct_ls/F90_HYPRE_struct_*.care updated so that all solvers support SMG, PFMG, SparseMSG, Jacobi and Diagonal Scaling as possible choices for the preconditioner. Previously, this support was incomplete. This is motivated by issue 1731 from hypre Issue Tracker.PS: should we keep supporting Jacobi and Diagonal Scaling in Struct? The latter can be used via the former one.