Improve macOS implementation and minor improvement to the shared components. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, layers are optional, so with the current implementation we assume that it is always there which is a wrong assumption. To fix this issue, we now set `wantsLayer` to `true` before adding the animation. ``` Setting the value of this property to true turns the view into a layer-backed view—that is, the view uses a CALayer object to manage its rendered content. Creating a layer-backed view implicitly causes the entire view hierarchy under that view to become layer-backed. Thus, the view and all of its subviews (including subviews of subviews) become layer-backed. The default value of this property is false. ```
Setting the image again can cause the view to blink as it will render the image on screen because the layer needs updating. By piggy backing on `transitionClosure`, it will animate from one image to another, but only if the old image exists. If the image view has no image, it will simply assign the image to self as the previous implementation did.
onmyway133
reviewed
Aug 28, 2017
| @@ -7,7 +7,7 @@ public extension Configuration { | |||
| } | |||
|
|
|||
| public static var transitionClosure: ((NSImageView, NSImage) -> Void) = { imageView, newImage in | |||
| guard let oldImage = imageView.image else { | |||
| guard let oldImage = imageView.image, imageView.window?.inLiveResize == false else { | |||
There was a problem hiding this comment.
@onmyway133 if the window is being actively resized.
A Boolean value indicating whether the view is being rendered as part of a live resizing operation.
onmyway133
approved these changes
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
wantsLayerto true before trying to add an animationOn macOS, layers are optional, so with the current implementation we
assume that it is always there which is a wrong assumption. To fix this
issue, we now set
wantsLayertotruebefore adding the animation.Use transition closure instead of setting the image
Setting the image again can cause the view to blink as it will render
the image on screen because the layer needs updating. By piggy backing
on
transitionClosure, it will animate from one image to another, butonly if the old image exists. If the image view has no image, it will
simply assign the image to self as the previous implementation did.
Opt-out from setting the image again if the window is resizing.