Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest pull from Upstream #2

Merged
merged 63 commits into from
Jun 8, 2019
Merged

Conversation

hypermine-bc
Copy link
Collaborator

No description provided.

mhajas and others added 30 commits April 29, 2019 13:48
…henticationFlowException when the authentictor returns ATTEMPTED.
Single quotes need to be represented by double single quotes throughout a String.
See: https://docs.oracle.com/javase/7/docs/api/java/text/MessageFormat.html
…to user is comletely blank with nonsense title
reda-alaoui and others added 29 commits May 23, 2019 14:16
This commit sends the STARTTLS on LDAP 389 connections is specified.
STARTTLS doesn't work with connection pooling so connection pooling will
be disabled should TLS be enabled.
KEYCLOAK-10393 Ensure idempotency of find method of permission ticket store
This adds support for the "S256" code_challenge_method to the JS Adapter.
Note that the method "plain" was deliberately left out as is not recommended
to be used in new applications.

Note that this PR includes two libraries:
- [base64-js]{@link https://github.com/beatgammit/base64-js}
- [js-sha256]{@link https://github.com/emn178/js-sha256}

`base64-js` is needed for cross-browser support for decoding the
Uint8ArrayBuffer returned by `crypto.getRandomValues` to a PKCE
compatible base64 string.

`js-sha256` library is required because the `crypto.subtle.digest`
support is not available for all browsers.

The PKCE codeVerifier is stored in the callbackStore of the JS Adapter.

Note: This PR is based on #5255 which got messed up during a rebase.
This is necessary for the example to function properly.  For example: without the other styles, the passwords are not hidden when updating user credentials.  Ideally, all the styles would be automatically inherited from keycloak but they don't appear to be.
@hypermine-bc hypermine-bc merged commit eaab3de into hypermine-bc:master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet