Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extending TxPaginationMeta #63

Merged
merged 10 commits into from
Sep 14, 2021
Merged

extending TxPaginationMeta #63

merged 10 commits into from
Sep 14, 2021

Conversation

Pawlak00
Copy link
Contributor

This is an attempt to add possibility of using extended TxPaginaitonMeta

Signed-off-by: Piotr Pawlowski <[email protected]>
Signed-off-by: Piotr Pawlowski <[email protected]>
@baziorek
Copy link
Member

The issue depends on features from hyperledger/iroha#1092

Copy link
Member

@baziorek baziorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked changes and found few things to change.
Unfortunately I'm not JS specialist.

For now please after changing my suggestions make the PR not draft.

example/chain.ts Outdated Show resolved Hide resolved
example/chain.ts Outdated Show resolved Hide resolved
@Pawlak00 Pawlak00 marked this pull request as ready for review August 3, 2021 16:44
Signed-off-by: Piotr Pawlowski <[email protected]>
Signed-off-by: Piotr Pawlowski <[email protected]>
Signed-off-by: Piotr Pawlowski <[email protected]>
Signed-off-by: Piotr Pawlowski <[email protected]>
Signed-off-by: Piotr Pawlowski <[email protected]>
@Pawlak00 Pawlak00 requested a review from baziorek August 11, 2021 19:42
Copy link
Member

@baziorek baziorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good for me, but I'm not JS programmer.

@LiraLemur LiraLemur merged commit 1cbefd1 into hyperledger:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants