New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] add allure annotation #196

Merged

0x009922 merged 7 commits into hyperledger:main from troferoller:ddulger

Sep 11, 2024

+231 −59

Contributor

troferoller commented Jun 24, 2024

No description provided.

troferoller force-pushed the ddulger branch from 0245697 to 4c38981 Compare

June 24, 2024 14:47

troferoller marked this pull request as ready for review

July 3, 2024 08:05

Contributor Author

troferoller commented Jul 3, 2024

reworked sometests

troferoller force-pushed the ddulger branch 2 times, most recently from fda3ef4 to 1e716d9 Compare

July 3, 2024 10:20

AlexStroke self-assigned this

AlexStroke suggested changes

View reviewed changes

packages/client/test/integration/test-node/test/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

AlexStroke assigned troferoller

AlexStroke suggested changes

View reviewed changes

allure-report_2024-07-15_17-23-10/data/categories.json Outdated Show resolved Hide resolved

troferoller force-pushed the ddulger branch from 56ef621 to ef7f3a7 Compare

July 18, 2024 13:35

AlexStroke approved these changes

View reviewed changes

AlexStroke suggested changes

View reviewed changes

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

AlexStroke assigned 0x009922

troferoller force-pushed the ddulger branch from ef7f3a7 to 55aa9ad Compare

July 22, 2024 23:52

troferoller requested a review from AlexStroke

July 24, 2024 14:53

AlexStroke suggested changes

View reviewed changes

packages/client/test/integration/test-node/test/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

0x009922 requested changes

View reviewed changes

Contributor

0x009922 left a comment

Format code with pnpm -w format:fix
Preferrably if you only add additions to compatibility.spec.ts and keep everything related to Allure there. I understand that some tests from main.spec.ts are ideologically useful for compat matrix - so, just move them into the compatibility.spec.ts

package.json Outdated Show resolved Hide resolved

.npmrc Outdated Show resolved Hide resolved

packages/client/test/api.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/main.spec.ts Outdated Show resolved Hide resolved

troferoller force-pushed the ddulger branch from 948c6f0 to 087d769 Compare

July 31, 2024 09:42

alexstroke1 assigned alexstroke1 and unassigned AlexStroke

alexstroke1 self-requested a review

August 1, 2024 07:14

0x009922 requested changes

View reviewed changes

Contributor

0x009922 left a comment

It may be not in my scope, but the use of steps is confusing in current implementation. Could you explain the rationale behind it?

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/api.spec.ts Outdated Show resolved Hide resolved


commit changed steps

Signed-off-by: Dmitriy Dulger <[email protected]>

troferoller force-pushed the ddulger branch from cd8c0f9 to 7982699 Compare

August 5, 2024 08:50


make special function

Signed-off-by: Dmitriy Dulger <[email protected]>

0x009922 reviewed

View reviewed changes

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

0x009922 reviewed

View reviewed changes

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

0x009922 reviewed

View reviewed changes

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved


rework beforeEach

bd48399

Signed-off-by: Dmitriy Dulger <[email protected]>

0x009922 requested changes

View reviewed changes

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

0x009922 requested changes

View reviewed changes

Contributor

0x009922 left a comment

Please apply changes to other steps in the same manner.

0x009922 reviewed

View reviewed changes

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/util.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/util.ts Outdated Show resolved Hide resolved


create special util for compatibility folder

1ac9e26

Signed-off-by: Dmitriy Dulger <[email protected]>

troferoller force-pushed the ddulger branch from 733eb46 to 1ac9e26 Compare

August 18, 2024 12:28


fix described step

a4e7269

Signed-off-by: Dmitriy Dulger <[email protected]>

0x009922 requested changes

View reviewed changes

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/compatibility.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/multisignature.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/compatibility/api.spec.ts Outdated Show resolved Hide resolved

packages/client/test/integration/test-node/test/util.ts Outdated Show resolved Hide resolved

Dmitriy Dulger and others added 2 commits

August 22, 2024 10:23


changed description steps

5aa5459

Signed-off-by: Dmitriy Dulger <[email protected]>


fix: chores

ad9e7ae

Signed-off-by: quacumque <[email protected]>

0x009922 approved these changes

View reviewed changes

0x009922 merged commit d05a87d into hyperledger:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment