build(deps): migrate from grpc to @grpc/grpc-js and make it a prod dependency #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendency BREAKING CHANGE: When creating a gRPC Iroha service instance such as `CommandService` or `QueryService` you have to make sure to create the credentials object that you will use to construct the service instances from the new gRPC library. Otherwise your code will throw, claiming that you have not passed in a valid credentials object (even though you did, just with the wrong version of the gRPC library) Primary changes: =============== 1. Migrate over from the legacy and unmaintained grpc to @grpc/grpc-js 2. Move from `devDependencies` to `dependencies` so that is a production dependency of the package. Secondary changes: ================== 1. Ignored the .yarn/cache directory in git so that there aren't 400 new files in the git index after a `yarn install` execution on the terminal. Fixes hyperledger#173 Signed-off-by: Peter Somogyvari <[email protected]>
baziorek
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
I'm not javascript specialist, but changes looks OK for me. What is more in comment: #173 (comment) Peter wrote that after changes: everything is working with Cacti. I was one of mentors of integration between Iroha 1 and Cacti (another mentor was Peter) and I know that when everything is working in the connection it means that everything will work in iroha-javascript after changing (all commands and queries were integrated + integration was well tested).
Links:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: When creating a gRPC Iroha service instance such as
CommandServiceorQueryServiceyou have to make sure to create thecredentials object that you will use to construct the service instances
from the new gRPC library. Otherwise your code will throw, claiming that
you have not passed in a valid credentials object (even though you did,
just with the wrong version of the gRPC library)
Primary changes:
devDependenciestodependenciesso that is a productiondependency of the package.
Secondary changes:
new files in the git index after a
yarn installexecution on the terminal.Fixes #173
Signed-off-by: Peter Somogyvari [email protected]