-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move grpc from devDependencies to dependencies #173
Comments
@outSH I will update you as soon as I get the decision on that matter. |
@6r1d Thanks for looking into that, any news so far? |
@outSH, I'm still looking for someone who could help. |
@6r1d This might help a little bit (but do let me know if it doesn't). The migration from |
…pendency Primary changes: =============== 1. Migrate over from the legacy and unmaintained grpc to @grpc/grpc-js 2. Move from `devDependencies` to `dependencies` so that is a production dependency of the package. Secondary changes: ================== 1. Ignored the .yarn/cache directory in git so that there aren't 400 new files in the git index after a `yarn install` execution on the terminal. Fixes hyperledger#173 Signed-off-by: Peter Somogyvari <[email protected]>
…pendency Primary changes: =============== 1. Migrate over from the legacy and unmaintained grpc to @grpc/grpc-js 2. Move from `devDependencies` to `dependencies` so that is a production dependency of the package. Secondary changes: ================== 1. Ignored the .yarn/cache directory in git so that there aren't 400 new files in the git index after a `yarn install` execution on the terminal. Fixes hyperledger#173 Signed-off-by: Peter Somogyvari <[email protected]>
…pendency Primary changes: =============== 1. Migrate over from the legacy and unmaintained grpc to @grpc/grpc-js 2. Move from `devDependencies` to `dependencies` so that is a production dependency of the package. Secondary changes: ================== 1. Ignored the .yarn/cache directory in git so that there aren't 400 new files in the git index after a `yarn install` execution on the terminal. Fixes hyperledger#173 Signed-off-by: Peter Somogyvari <[email protected]>
…pendency BREAKING CHANGE: When creating a gRPC Iroha service instance such as `CommandService` or `QueryService` you have to make sure to create the credentials object that you will use to construct the service instances from the new gRPC library. Otherwise your code will throw, claiming that you have not passed in a valid credentials object (even though you did, just with the wrong version of the gRPC library) Primary changes: =============== 1. Migrate over from the legacy and unmaintained grpc to @grpc/grpc-js 2. Move from `devDependencies` to `dependencies` so that is a production dependency of the package. Secondary changes: ================== 1. Ignored the .yarn/cache directory in git so that there aren't 400 new files in the git index after a `yarn install` execution on the terminal. Fixes hyperledger#173 Signed-off-by: Peter Somogyvari <[email protected]>
TBH, I am not sure why this error occurs in runtime, because However, With this in mind, I've approved #174. upd: I am blind, just saw #182, nevermind. |
grpc
is a dependency ofiroha-helpers
(irohaV1) but it's listed underdevDependencies
instead ofdependencies
. This causes error when user doesn't have grpc installed. Issue occured at our project (Hyperledger Cacti) when we updated from deprecated grpc to grpc-js.To reproduce initialize empty TS nodejs project,
npm i iroha-helpers
(only), compile the following:And run. Error printed:
The text was updated successfully, but these errors were encountered: