Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-17863] Enhance rebuild-dbs to drop CouchDB state database #1235

Merged
merged 1 commit into from
May 11, 2020

Conversation

wenjianqiao
Copy link
Contributor

Signed-off-by: Wenjian Qiao [email protected]

Type of change

  • Improvement (improvement to code, performance, etc)

Description

The rebuild-dbs command should be able to drop CouchDB state db.

Related issues

https://jira.hyperledger.org/browse/FAB-17863

The rebuild-dbs command should be able to drop CouchDB state db.

Signed-off-by: Wenjian Qiao <[email protected]>
@wenjianqiao wenjianqiao requested a review from a team as a code owner May 11, 2020 16:47
@manish-sethi
Copy link
Contributor

manish-sethi commented May 11, 2020

LGTM. However, to take a note of two related things

  • A test can be added in the kvledger/tests level to check for error propagation for APIs such as upgrade and rebuild, when the couchdb is not running
  • Just an orthogonal thought, we can also do the actual rebuild inside the functions "Rebuild and UpgradeDB" to actually justify the API names. That way, admin commands will be more aligned as well and the peer start next time would be no different from a regular peer start - wdyt?

@manish-sethi manish-sethi merged commit 3034976 into hyperledger:master May 11, 2020
@wenjianqiao wenjianqiao deleted the fab17863 branch May 11, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants