Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameterized acceptance tests so they enumerate with --dry-run #7498

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Aug 20, 2024

PR description

Related to this #7317, we need to add a dummy @test to be sure parameterized ATs are selected, at least until gradle/gradle#29895 is fixed

Fixed Issue(s)

fixes #7490

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla macfarla merged commit aaf74a6 into hyperledger:main Aug 20, 2024
40 checks passed
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ATs - not all are running in GHA
2 participants