Implemented private log filter JSON-RPC methods #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4362e0a
to
305e545
Compare
Signed-off-by: Lucas Saldanha <[email protected]>
305e545
to
705af02
Compare
lucassaldanha
commented
Apr 17, 2020
|
|
||
| private void addMatchingLogs(final LogFilter filter) { | ||
| final long headBlockNumber = blockchainQueries.headBlockNumber(); | ||
| private void addNewMatchingLogs(final LogFilter filter) { |
There was a problem hiding this comment.
I renamed this method to clarify that we will only be looking for new logs here. The fromBlockNumber is set to the head of the chain.
lucassaldanha
commented
Apr 17, 2020
| return findLogsWithinRange(filter, fromBlockNumber, toBlockNumber); | ||
| } | ||
|
|
||
| private List<LogWithMetadata> findLogsWithinRange( |
There was a problem hiding this comment.
This method was introduced to avoid duplication. It is used by two methods in this class.
pinges
approved these changes
Apr 20, 2020
...va/org/hyperledger/besu/ethereum/api/jsonrpc/internal/privacy/methods/PrivGetFilterLogs.java
Show resolved
Hide resolved
...perledger/besu/ethereum/api/jsonrpc/internal/privacy/methods/priv/PrivGetFilterLogsTest.java
Outdated
Show resolved
Hide resolved
...ledger/besu/ethereum/api/jsonrpc/internal/privacy/methods/priv/PrivGetFilterChangesTest.java
Outdated
Show resolved
Hide resolved
...g/hyperledger/besu/ethereum/api/jsonrpc/internal/privacy/methods/priv/PrivNewFilterTest.java
Show resolved
Hide resolved
...rledger/besu/ethereum/api/jsonrpc/internal/privacy/methods/priv/PrivUninstallFilterTest.java
Show resolved
Hide resolved
Signed-off-by: Lucas Saldanha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #627
Implemented the following JSON-RPC methods:
• priv_installFilter
• priv_uninstallFilter
• priv_getFilterLogs
• priv_getFilterChanges
ATs will be implemented in a separate PR.