Multithread Websockets to increase throughput #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertx by default orders all calls to executeBlocking in an ordered fashion. As a side effect all requests are single threaded, even across multiple clients. Because JSON-RPC has request identifiers it is not needed to thread responses as they can be answered out of order. This also allows multiple threads to handle requests, increasing throughput. Signed-off-by: Danno Ferrin <[email protected]>
lucassaldanha
approved these changes
Dec 2, 2019
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Vertx by default orders all calls to executeBlocking in an ordered fashion. As a side effect all requests are single threaded, even across multiple clients. Because JSON-RPC has request identifiers it is not needed to thread responses as they can be answered out of order. This also allows multiple threads to handle requests, increasing throughput. Signed-off-by: Danno Ferrin <[email protected]>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Vertx by default orders all calls to executeBlocking in an ordered fashion. As a side effect all requests are single threaded, even across multiple clients. Because JSON-RPC has request identifiers it is not needed to thread responses as they can be answered out of order. This also allows multiple threads to handle requests, increasing throughput. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: edwardmack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertx by default orders all calls to executeBlocking in an ordered
fashion. As a side effect all requests are single threaded, even across
multiple clients. Because JSON-RPC has request identifiers it is not
needed to thread responses as they can be answered out of order. This
also allows multiple threads to handle requests, increasing throughput.
Signed-off-by: Danno Ferrin <[email protected]>
Release Notes
Performance Improvements in Websockets.