Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize High Gas Price Transactions #1449

Merged
merged 6 commits into from
Oct 14, 2020

Conversation

RatanRSur
Copy link
Contributor

@RatanRSur RatanRSur commented Oct 13, 2020

Fixed Issue(s)

fixes #1285

Changelog

Credit

credit to @JoshMelton for initial work.

@RatanRSur RatanRSur changed the title Issue 1285 Prioritize High Gas Price Transactions Oct 13, 2020
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Only reviewed the code on Github.
Did you do manual testing as well ?

@RatanRSur
Copy link
Contributor Author

Maybe once I fix the unit tests I broke I can think about that 😅

@RatanRSur
Copy link
Contributor Author

@NicolasMassart @MadelineMurray told me to ping y'all when this is addressed. We now drop the remote, lowest gas-price, oldest transaction. Before we just sorted by remote and oldest.

@RatanRSur RatanRSur merged commit e0e7a6f into hyperledger:master Oct 14, 2020
@RatanRSur RatanRSur deleted the issue-1285 branch October 14, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Transactions By Gas Price and then By Time Added To Pool
3 participants