Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin registry used for protocol and admin route registration #257

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

andrewwhitehead
Copy link
Member

Supercedes PR #248

@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #257 into master will increase coverage by 0.16%.
The diff coverage is 97.18%.

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   74.56%   74.73%   +0.16%     
==========================================
  Files         232      231       -1     
  Lines       10395    10408      +13     
==========================================
+ Hits         7751     7778      +27     
+ Misses       2644     2630      -14

@nrempel nrempel merged commit 5ee3ebc into hyperledger:master Nov 8, 2019
Copy link
Member

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm late but, for the record, I like these changes. Thanks for being open to my proposal!

@andrewwhitehead andrewwhitehead deleted the feature/plugin-registry branch February 29, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants