Align Forward message with RFC 0094: msg must be JSON dict, not a string

[jovfer]

As defined in the RFC nested msg in Forward must be nested JSON object returned by pack message

https://github.com/hyperledger/aries-rfcs/tree/master/concepts/0094-cross-domain-messaging#corerouting10forward

[codecov-io]

Codecov Report

Merging #240 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   73.51%   73.51%   +<.01%     
==========================================
  Files         219      219              
  Lines       10267    10268       +1     
==========================================
+ Hits         7548     7549       +1     
  Misses       2719     2719

[jovfer]

@kdenhartog FYI

[swcurran]

As I understand it, this PR matches the RFC. @andrewwhitehead @tmarkovski - how can we resolve this? Do we need to coordinate new releases of Streetcred Mobile app and ACA-Py to get this changed?

Thanks

[tmarkovski]

Yes, we need to coordinate the release to avoid breaking changes. I'm a little unclear though, libindy returns the pack result as string, but the forward wants it as object. In strongly typed languages this adds a step of converting the string to a JSON first. What is the reason for the type change in the forward message? Especially since we talked about reworking the routing standard?

[swcurran]

@jovfer @tmarkovski @andrewwhitehead - could one of you take the lead on this for discussion on the next Aries Working Group call so we can get this clarified and an approach defined?

@TelegramSam - could you add this to the agenda?

[esplinr]

It sounds like the change is made in Street Cred (please correct if I'm wrong @tmarkovski). Does that mean we can accept this PR so that we have increased interoperability in the next release of ACA-py?

[swcurran]

Sigh... No notes in the issue, no update on what we planned to do. #frustrating.

Does anyone know where we documented what we would do?

@andrewwhitehead - did we decide anything on this? I thought we weren't going to do anything, but I can't find anything about what was decided. Thanks.

[ianco]

I think we just need to merge this PR.

FYI I made these same changes on a local branch and tested interconnectivity between aca-py and VCX successfully.

[swcurran]

Did that branch also work with Streetcred? Does it work with Streetcred?

…

On Wed, Jan 22, 2020 at 1:53 PM Ian Costanzo ***@***.***> wrote: I think we just need to merge this PR. FYI I made these same changes on a local branch and tested interconnectivity between aca-py and VCX successfully. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#240?email_source=notifications&email_token=AAHYRQUDDTTQIDQSCZXUUQLQ7C56VA5CNFSM4JFX5QTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJVHWMY#issuecomment-577403699>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHYRQTR342MRATPJ2MC2P3Q7C56VANCNFSM4JFX5QTA> .

-- Stephen Curran Principal, Cloud Compass Computing, Inc. (C3I) Technical Governance Board Member - Sovrin Foundation (sovrin.org) *Schedule a Meeting: **https://calendly.com/swcurran <https://calendly.com/swcurran>*

[tmarkovski]

@swcurran This feature is currently implemented in Aries .NET and tested for interop with Vcx.
Streetcred hasn't applied this specific version to our mobile app or agents, but will do so with the Jan 30 release.

[swcurran]

Our plan is to merge this now and package. When the Streetcred agent hits the App Store, we'll immediately redeploy all our apps so that we minimize the down time.

@andrewwhitehead - please go ahead with the merge and plan out the rest of the 0.4.1 changes.

Hopefully we don't have to do this break production dance in the future. AIP and the community upgrade process will help with this. On a positive note, we can do the work ahead of time to get the deployments ready to go.

@WadeBarnes @esune - you will be getting 0.4.1 images soon and we'll need to have a list of redeployments done as soon as we hear the new Streetcred app is in the app store. I'll add a ticket for this in the von repo.

@tmarkovski - please let us know when the app is in the app store.

Thanks!